Enable codecov

* Use named variables for getting path
Fixed bug with env var

* Fix test

* Use utils to get paths

.github/workflows/go.yml

@@ -22,7 +22,7 @@ jobs:
       run: make build
     - name: Test
       run: make test-with-coverage
-    # - uses: codecov/codecov-action@v1
+    - uses: codecov/codecov-action@v1
-    #   with:
+      with:
-    #     token: ${{ secrets.CODECOV_TOKEN }}
+        token: ${{ secrets.CODECOV_TOKEN }}
-    #     files: coverage.out
+        files: coverage.out

Makefile

@@ -13,7 +13,7 @@ build-prod:
 	GOOS=linux GOARCH=arm RELEASE=prod make build
 
 build-cloud:
-	CGO_ENABLED=1 GOOS=linux GOARCH=amd64 RELEASE=cloud make build
+	GOOS=linux GOARCH=amd64 RELEASE=cloud make build
 
 build:
 	@echo "Building ${GOOS}-${GOARCH}"

cmd/edgeboxctl/main.go

@@ -1,6 +1,7 @@
 package main
 
 import (
+	"flag"
 	"fmt"
 	"log"
 	"os"
@@ -11,304 +12,32 @@ import (
 	"github.com/edgebox-iot/edgeboxctl/internal/diagnostics"
 	"github.com/edgebox-iot/edgeboxctl/internal/tasks"
 	"github.com/edgebox-iot/edgeboxctl/internal/utils"
-	"github.com/mitchellh/colorstring"
-	"github.com/urfave/cli/v2" // imports as package "cli",
 )
 
 const defaultNotReadySleepTime time.Duration = time.Second * 60
 const defaultSleepTime time.Duration = time.Second
 
-var errorMissingApplicationSlug = colorstring.Color("[red]Error: [white]Missing application slug")
-var errorSystemNotReady = colorstring.Color("[red]Eror: [white]The system is not ready to run. \n[white]Please run 'cd /home/system/components/ws/ && ./ws -b' first.")
-var errorNotYetImplemented = colorstring.Color("[yellow]This feature is not yet implemented, this command is only a stub.")
-
 func main() {
 
-	app := &cli.App{
+	// load command line arguments
-		Name:  "edgeboxctl",
-		Usage: "A tool to facilitate hosting apps and securing your personal data",
-		Action: func(c *cli.Context) error {
-			startService() // Defaults to start as a service if no commands or flags are passed
-			return nil
-		},
-		Commands: []*cli.Command{
-			{
-				Name:    "bootstrap",
-				Aliases: []string{"b"},
-				Usage:   "Sets up initial structure and dependencies for the edgebox system",
-				Action: func(c *cli.Context) error {
-					return cli.Exit(errorNotYetImplemented, 1)
-				},
-			},
-			{
-				Name:    "tunnel",
-				Aliases: []string{"t"},
-				Usage:   "Edgebox tunnel settings",
-				Subcommands: []*cli.Command{
-					{
-						Name:    "setup",
-						Aliases: []string{"s"},
-						Usage:   "Sets up an encrypted secure connection to a tunnel",
-						Before:  canRunCommands,
-						Action: func(c *cli.Context) error {
 
-							argumentError := checkArgumentsPresence(c, 4)
+	version := flag.Bool("version", false, "Get the version info")
-							if argumentError != nil {
+	db := flag.Bool("database", false, "Get database connection info")
-								return argumentError
+	name := flag.String("name", "edgebox", "Name for the service")
-							}
 
-							task := getCommandTask(
+	flag.Parse()
-								"setup_tunnel",
-								fmt.Sprintf(
-									"{\"bootnode_address\": \"%s\", \"token\": \"%s\", \"assigned_address\": \"%s\", \"node_name\": \"%s\"}",
-									c.Args().Get(0),
-									c.Args().Get(1),
-									c.Args().Get(2),
-									c.Args().Get(3),
-								),
-								true,
-							)
 
-							return cli.Exit(utils.ColorJsonString(task.Result.String), 0)
+	if *version {
-						},
+		printVersion()
-					},
+		os.Exit(0)
-					{
-						Name:    "enable",
-						Aliases: []string{"e"},
-						Usage:   "enables the public tunnel (when configured)",
-						Before:  canRunCommands,
-						Action: func(c *cli.Context) error {
-							return cli.Exit(errorNotYetImplemented, 1)
-						},
-					},
-					{
-						Name:    "disable",
-						Aliases: []string{"d"},
-						Usage:   "disables the public tunnel (when online)",
-						Before:  canRunCommands,
-						Action: func(c *cli.Context) error {
-							return cli.Exit(errorNotYetImplemented, 1)
-						},
-					},
-				},
-			},
-			{
-				Name:    "app",
-				Aliases: []string{"a"},
-				Usage:   "options for edgeapp management",
-				Subcommands: []*cli.Command{
-					{
-						Name:    "list",
-						Aliases: []string{"l"},
-						Usage:   "list currently installed apps and their status",
-						Before:  canRunCommands,
-						Action: func(c *cli.Context) error {
-							task := getCommandTask("list_edgeapps", "", true)
-							// return cli.Exit(utils.ColorJsonString(task.Result.String), 0)
-							return cli.Exit(task.Result.String, 0)
-						},
-					},
-					{
-						Name:    "install",
-						Aliases: []string{"i"},
-						Usage:   "install the specified app (slug or package file)",
-						Before:  canRunCommands,
-						Action: func(c *cli.Context) error {
-
-							argumentError := checkArgumentsPresence(c, 1)
-							if argumentError != nil {
-								return argumentError
-							}
-
-							task := getCommandTask("install_edgeapp", fmt.Sprintf("{\"id\": \"%s\"}", c.Args().First()), true)
-
-							return cli.Exit(utils.ColorJsonString(task.Result.String), 0)
-						},
-					},
-					{
-						Name:    "remove",
-						Aliases: []string{"r"},
-						Usage:   "remove the specified app",
-						Before:  canRunCommands,
-						Action: func(c *cli.Context) error {
-
-							argumentError := checkArgumentsPresence(c, 1)
-							if argumentError != nil {
-								return argumentError
-							}
-
-							task := getCommandTask("remove_edgeapp", fmt.Sprintf("{\"id\": \"%s\"}", c.Args().First()), true)
-
-							return cli.Exit(utils.ColorJsonString(task.Result.String), 0)
-						},
-					},
-					{
-						Name:    "start",
-						Aliases: []string{"s"},
-						Usage:   "start the specified app",
-						Before:  canRunCommands,
-						Action: func(c *cli.Context) error {
-
-							argumentError := checkArgumentsPresence(c, 1)
-							if argumentError != nil {
-								return argumentError
-							}
-
-							task := getCommandTask("start_edgeapp", fmt.Sprintf("{\"id\": \"%s\"}", c.Args().First()), true)
-
-							return cli.Exit(utils.ColorJsonString(task.Result.String), 0)
-						},
-					},
-					{
-						Name:    "stop",
-						Aliases: []string{"k"},
-						Usage:   "stop the specified app",
-						Before:  canRunCommands,
-						Action: func(c *cli.Context) error {
-
-							argumentError := checkArgumentsPresence(c, 1)
-							if argumentError != nil {
-								return argumentError
-							}
-
-							task := getCommandTask("stop_edgeapp", fmt.Sprintf("{\"id\": \"%s\"}", c.Args().First()), true)
-
-							return cli.Exit(utils.ColorJsonString(task.Result.String), 0)
-						},
-					},
-					{
-						Name:    "online",
-						Aliases: []string{"o"},
-						Usage:   "set an app status for online access",
-						Subcommands: []*cli.Command{
-							{
-								Name:    "enable",
-								Aliases: []string{"e"},
-								Usage:   "set an app as accessible online",
-								Before:  canRunCommands,
-								Action: func(c *cli.Context) error {
-
-									argumentError := checkArgumentsPresence(c, 2)
-									if argumentError != nil {
-										return argumentError
-									}
-
-									task := getCommandTask(
-										"enable_online",
-										fmt.Sprintf(
-											"{\"id\": \"%s\", \"internet_url\": \"%s\"}",
-											c.Args().Get(0),
-											c.Args().Get(1),
-										),
-										true,
-									)
-
-									return cli.Exit(utils.ColorJsonString(task.Result.String), 0)
-								},
-							},
-							{
-								Name:    "disable",
-								Aliases: []string{"d"},
-								Usage:   "set an app as local-network private",
-								Before:  canRunCommands,
-								Action: func(c *cli.Context) error {
-
-									argumentError := checkArgumentsPresence(c, 1)
-									if argumentError != nil {
-										return argumentError
-									}
-
-									task := getCommandTask("disable_online", fmt.Sprintf("{\"id\": \"%s\"}", c.Args().First()), true)
-
-									return cli.Exit(utils.ColorJsonString(task.Result.String), 0)
-								},
-							},
-						},
-					},
-				},
-			},
-			{
-				Name:    "dashboard",
-				Aliases: []string{"d"},
-				Usage:   "set dashboard access",
-				Subcommands: []*cli.Command{
-					{
-						Name:    "enable",
-						Aliases: []string{"e"},
-						Usage:   "enable dashboard access",
-						Before:  canRunCommands,
-						Action: func(c *cli.Context) error {
-							argumentError := checkArgumentsPresence(c, 1)
-							if argumentError != nil {
-								return argumentError
-							}
-
-							task := getCommandTask("enable_public_dashboard", fmt.Sprintf("{\"internet_url\": \"%s\"}", c.Args().First()), true)
-							return cli.Exit(utils.ColorJsonString(task.Result.String), 0)
-						},
-					},
-					{
-						Name:    "disable",
-						Aliases: []string{"d"},
-						Usage:   "disable dashboard access",
-						Before:  canRunCommands,
-						Action: func(c *cli.Context) error {
-
-							argumentError := checkArgumentsPresence(c, 1)
-							if argumentError != nil {
-								return argumentError
-							}
-
-							task := getCommandTask("disable_public_dashboard", "", true)
-							return cli.Exit(utils.ColorJsonString(task.Result.String), 0)
-
-						},
-					},
-				},
-			},
-		},
 	}
 
-	err := app.Run(os.Args)
+	if *db {
-	if err != nil {
+		printDbDetails()
-		log.Fatal(err)
+		os.Exit(0)
-	}
-}
-
-func canRunCommands(c *cli.Context) error {
-	if !utils.IsSystemReady() {
-		return cli.Exit(errorSystemNotReady, 1)
 	}
 
-	return nil
+	log.Printf("Starting edgeboxctl service for %s", *name)
-}
-
-func checkArgumentsPresence(c *cli.Context, count int) error {
-	if count != 0 {
-		for i := 0; i < count; i++ {
-			if c.Args().Get(i) == "" {
-				return cli.Exit(errorMissingApplicationSlug, 1)
-			}
-		}
-	}
-	return nil
-}
-
-func getCommandTask(taskSlug string, taskArgs string, execute bool) tasks.Task {
-	task := tasks.GetBaseTask(
-		taskSlug,
-		taskArgs,
-	)
-
-	if execute {
-		task = tasks.ExecuteTask(task)
-	}
-
-	return task
-}
-
-func startService() {
-	log.Printf("Starting edgeboxctl service")
 
 	// setup signal catching
 	sigs := make(chan os.Signal, 1)
@@ -328,6 +57,7 @@ func startService() {
 	}()
 
 	printVersion()
+
 	printDbDetails()
 
 	tick := 0
@@ -335,9 +65,9 @@ func startService() {
 	// infinite loop
 	for {
 
-		if utils.IsSystemReady() {
+		if isSystemReady() {
 			tick++ // Tick is an int, so eventually will "go out of ticks?" Maybe we want to reset the ticks every once in a while, to avoid working with big numbers...
-			systemIterator(tick)
+			systemIterator(name, tick)
 		} else {
 			// Wait about 60 seconds before trying again.
 			log.Printf("System not ready. Next try will be executed in 60 seconds")
@@ -345,6 +75,7 @@ func startService() {
 		}
 
 	}
+
 }
 
 // AppCleanup : cleanup app state before exit
@@ -366,7 +97,18 @@ func printDbDetails() {
 	)
 }
 
-func systemIterator(tick int) {
+// IsSystemReady : Checks hability of the service to execute commands (Only after "edgebox --build" is ran at least once via SSH, or if built for distribution)
+func isSystemReady() bool {
+	_, err := os.Stat(utils.GetPath(utils.WsPath) + ".ready")
+	return !os.IsNotExist(err)
+}
+
+// IsDatabaseReady : Checks is it can successfully connect to the task queue db
+func isDatabaseReady() bool {
+	return false
+}
+
+func systemIterator(name *string, tick int) {
 
 	log.Printf("Tick is %d", tick)
 
@@ -383,7 +125,7 @@ func systemIterator(tick int) {
 		log.Printf("No tasks to execute.")
 	}
 
-	// Wait about 1 second before resuming operations.
+	// Wait about 1 second before resumming operations.
 	log.Printf("Next instruction will be executed 1 second")
 	time.Sleep(defaultSleepTime)
 

codecov.yml

@@ -1,4 +1,3 @@
-codecov:
-  require_ci_to_pass: no
-
 comment: false
+github_checks:
+  annotations: false

go.mod

@@ -4,19 +4,14 @@ go 1.15
 
 require (
 	github.com/StackExchange/wmi v0.0.0-20210224194228-fe8f1750fd46 // indirect
-	github.com/TylerBrock/colorjson v0.0.0-20200706003622-8a50f05110d2 // indirect
 	github.com/dariubs/percent v0.0.0-20200128140941-b7801cf1c7e2 // indirect
 	github.com/dustin/go-humanize v1.0.0 // indirect
-	github.com/fatih/color v1.13.0 // indirect
 	github.com/go-ole/go-ole v1.2.5 // indirect
 	github.com/go-sql-driver/mysql v1.5.0
 	github.com/joho/godotenv v1.3.0
-	github.com/mattn/go-colorable v0.1.12 // indirect
 	github.com/mattn/go-sqlite3 v1.14.7 // indirect
-	github.com/mitchellh/colorstring v0.0.0-20190213212951-d06e56a500db // indirect
 	github.com/shirou/gopsutil v3.21.4+incompatible // indirect
 	github.com/tklauser/go-sysconf v0.3.6 // indirect
-	github.com/urfave/cli/v2 v2.3.0 // indirect
+	golang.org/x/sys v0.0.0-20210531080801-fdfd190a6549 // indirect
-	golang.org/x/sys v0.0.0-20220204135822-1c1b9b1eba6a // indirect
 	gopkg.in/yaml.v2 v2.4.0
 )

go.sum

@@ -1,18 +1,12 @@
 github.com/BurntSushi/toml v0.3.1/go.mod h1:xHWCNGjB5oqiDr8zfno3MHue2Ht5sIBksp03qcyfWMU=
 github.com/StackExchange/wmi v0.0.0-20210224194228-fe8f1750fd46 h1:5sXbqlSomvdjlRbWyNqkPsJ3Fg+tQZCbgeX1VGljbQY=
 github.com/StackExchange/wmi v0.0.0-20210224194228-fe8f1750fd46/go.mod h1:3eOhrUMpNV+6aFIbp5/iudMxNCF27Vw2OZgy4xEx0Fg=
-github.com/TylerBrock/colorjson v0.0.0-20200706003622-8a50f05110d2 h1:ZBbLwSJqkHBuFDA6DUhhse0IGJ7T5bemHyNILUjvOq4=
-github.com/TylerBrock/colorjson v0.0.0-20200706003622-8a50f05110d2/go.mod h1:VSw57q4QFiWDbRnjdX8Cb3Ow0SFncRw+bA/ofY6Q83w=
-github.com/cpuguy83/go-md2man/v2 v2.0.0-20190314233015-f79a8a8ca69d h1:U+s90UTSYgptZMwQh2aRr3LuazLJIa+Pg3Kc1ylSYVY=
-github.com/cpuguy83/go-md2man/v2 v2.0.0-20190314233015-f79a8a8ca69d/go.mod h1:maD7wRr/U5Z6m/iR4s+kqSMx2CaBsrgA7czyZG/E6dU=
 github.com/dariubs/percent v0.0.0-20200128140941-b7801cf1c7e2 h1:5EPE4Uk7ucthLTJAZqZxu6LZluox5/AqXUxJDpzgJjg=
 github.com/dariubs/percent v0.0.0-20200128140941-b7801cf1c7e2/go.mod h1:NDZpkezJ8QqyIW/510MywB5T2KdC8v/0oTlEoPcMsRM=
 github.com/davecgh/go-spew v1.1.0/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38=
 github.com/davecgh/go-spew v1.1.1/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38=
 github.com/dustin/go-humanize v1.0.0 h1:VSnTsYCnlFHaM2/igO1h6X3HA71jcobQuxemgkq4zYo=
 github.com/dustin/go-humanize v1.0.0/go.mod h1:HtrtbFcZ19U5GC7JDqmcUSB87Iq5E25KnS6fMYU6eOk=
-github.com/fatih/color v1.13.0 h1:8LOYc1KYPPmyKMuN8QV2DNRWNbLo6LZ0iLs8+mlH53w=
-github.com/fatih/color v1.13.0/go.mod h1:kLAiJbzzSOZDVNGyDpeOxJ47H46qBXwg5ILebYFFOfk=
 github.com/go-ole/go-ole v1.2.5 h1:t4MGB5xEDZvXI+0rMjjsfBsD7yAgp/s9ZDkL1JndXwY=
 github.com/go-ole/go-ole v1.2.5/go.mod h1:pprOEPIfldk/42T2oK7lQ4v4JSDwmV0As9GaiUsvbm0=
 github.com/go-sql-driver/mysql v1.5.0 h1:ozyZYNQW3x3HtqT1jira07DN2PArx2v7/mN66gGcHOs=
@@ -24,25 +18,13 @@ github.com/kisielk/gotool v1.0.0/go.mod h1:XhKaO+MFFWcvkIS/tQcRk01m1F5IRFswLeQ+o
 github.com/kr/pretty v0.1.0/go.mod h1:dAy3ld7l9f0ibDNOQOHHMYYIIbhfbHSm3C4ZsoJORNo=
 github.com/kr/pty v1.1.1/go.mod h1:pFQYn66WHrOpPYNljwOMqo10TkYh1fy3cYio2l3bCsQ=
 github.com/kr/text v0.1.0/go.mod h1:4Jbv+DJW3UT/LiOwJeYQe1efqtUx/iVham/4vfdArNI=
-github.com/mattn/go-colorable v0.1.9/go.mod h1:u6P/XSegPjTcexA+o6vUJrdnUu04hMope9wVRipJSqc=
-github.com/mattn/go-colorable v0.1.12 h1:jF+Du6AlPIjs2BiUiQlKOX0rt3SujHxPnksPKZbaA40=
-github.com/mattn/go-colorable v0.1.12/go.mod h1:u5H1YNBxpqRaxsYJYSkiCWKzEfiAb1Gb520KVy5xxl4=
-github.com/mattn/go-isatty v0.0.12/go.mod h1:cbi8OIDigv2wuxKPP5vlRcQ1OAZbq2CE4Kysco4FUpU=
-github.com/mattn/go-isatty v0.0.14 h1:yVuAays6BHfxijgZPzw+3Zlu5yQgKGP2/hcQbHb7S9Y=
-github.com/mattn/go-isatty v0.0.14/go.mod h1:7GGIvUiUoEMVVmxf/4nioHXj79iQHKdU27kJ6hsGG94=
 github.com/mattn/go-sqlite3 v1.14.7 h1:fxWBnXkxfM6sRiuH3bqJ4CfzZojMOLVc0UTsTglEghA=
 github.com/mattn/go-sqlite3 v1.14.7/go.mod h1:NyWgC/yNuGj7Q9rpYnZvas74GogHl5/Z4A/KQRfk6bU=
-github.com/mitchellh/colorstring v0.0.0-20190213212951-d06e56a500db h1:62I3jR2EmQ4l5rM/4FEfDWcRD+abF5XlKShorW5LRoQ=
-github.com/mitchellh/colorstring v0.0.0-20190213212951-d06e56a500db/go.mod h1:l0dey0ia/Uv7NcFFVbCLtqEBQbrT4OCwCSKTEv6enCw=
 github.com/pkg/errors v0.8.1/go.mod h1:bwawxfHBFNV+L2hUp1rHADufV3IMtnDRdf1r5NINEl0=
 github.com/pmezard/go-difflib v1.0.0/go.mod h1:iKH77koFhYxTK1pcRnkKkqfTogsbg7gZNVY4sRDYZ/4=
 github.com/rogpeppe/go-internal v1.3.0/go.mod h1:M8bDsm7K2OlrFYOpmOWEs/qY81heoFRclV5y23lUDJ4=
-github.com/russross/blackfriday/v2 v2.0.1 h1:lPqVAte+HuHNfhJ/0LC98ESWRz8afy9tM/0RK8m9o+Q=
-github.com/russross/blackfriday/v2 v2.0.1/go.mod h1:+Rmxgy9KzJVeS9/2gXHxylqXiyQDYRxCVz55jmeOWTM=
 github.com/shirou/gopsutil v3.21.4+incompatible h1:fuHcTm5mX+wzo542cmYcV9RTGQLbnHLI5SyQ5ryTVck=
 github.com/shirou/gopsutil v3.21.4+incompatible/go.mod h1:5b4v6he4MtMOwMlS0TUMTu2PcXUg8+E1lC7eC3UO/RA=
-github.com/shurcooL/sanitized_anchor_name v1.0.0 h1:PdmoCO6wvbs+7yrJyMORt4/BmY5IYyJwS/kOiWx8mHo=
-github.com/shurcooL/sanitized_anchor_name v1.0.0/go.mod h1:1NzhyTcUVG4SuEtjjoZeVRXNmyL/1OwPU0+IJeTBvfc=
 github.com/stretchr/objx v0.1.0/go.mod h1:HFkY916IF+rwdDfMAkV7OtwuqBVzrE8GR6GFx+wExME=
 github.com/stretchr/testify v1.3.0/go.mod h1:M5WIy9Dh21IEIfnGCwXGc5bZfKNJtfHm1UVUgZn+9EI=
 github.com/stretchr/testify v1.4.0/go.mod h1:j7eGeouHqKxXV5pUuKE4zz7dFj8WfuZ+81PSLYec5m4=
@@ -50,8 +32,6 @@ github.com/tklauser/go-sysconf v0.3.6 h1:oc1sJWvKkmvIxhDHeKWvZS4f6AW+YcoguSfRF2/
 github.com/tklauser/go-sysconf v0.3.6/go.mod h1:MkWzOF4RMCshBAMXuhXJs64Rte09mITnppBXY/rYEFI=
 github.com/tklauser/numcpus v0.2.2 h1:oyhllyrScuYI6g+h/zUvNXNp1wy7x8qQy3t/piefldA=
 github.com/tklauser/numcpus v0.2.2/go.mod h1:x3qojaO3uyYt0i56EW/VUYs7uBvdl2fkfZFu0T9wgjM=
-github.com/urfave/cli/v2 v2.3.0 h1:qph92Y649prgesehzOrQjdWyxFOp/QVM+6imKHad91M=
-github.com/urfave/cli/v2 v2.3.0/go.mod h1:LJmUH05zAU44vOAcrfzZQKsZbVcdbOG8rtL3/XcUArI=
 go.uber.org/atomic v1.6.0 h1:Ezj3JGmsOnG1MoRWQkPBsKLe9DwWD9QeXzTRzzldNVk=
 go.uber.org/atomic v1.6.0/go.mod h1:sABNBOSYdrvTF6hTgEIbc7YasKWGhgEQZyfxyTvoXHQ=
 go.uber.org/atomic v1.7.0 h1:ADUqmZGgLDDfbSL9ZmPxKTybcoEYHgpYfELNoN+7hsw=
@@ -74,15 +54,9 @@ golang.org/x/sync v0.0.0-20190423024810-112230192c58/go.mod h1:RxMgew5VJxzue5/jJ
 golang.org/x/sys v0.0.0-20190215142949-d0b11bdaac8a/go.mod h1:STP8DvDyc/dI5b8T5hshtkjS+E42TnysNCUPdjciGhY=
 golang.org/x/sys v0.0.0-20190412213103-97732733099d/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs=
 golang.org/x/sys v0.0.0-20190916202348-b4ddaad3f8a3/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs=
-golang.org/x/sys v0.0.0-20200116001909-b77594299b42/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs=
-golang.org/x/sys v0.0.0-20200223170610-d5e6a3e2c0ae/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs=
 golang.org/x/sys v0.0.0-20210316164454-77fc1eacc6aa/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs=
 golang.org/x/sys v0.0.0-20210531080801-fdfd190a6549 h1:OL5GcZ2XPkte3dpfuFQ9o884vrE3BZQhajdntNMruv4=
 golang.org/x/sys v0.0.0-20210531080801-fdfd190a6549/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg=
-golang.org/x/sys v0.0.0-20210630005230-0f9fa26af87c/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg=
-golang.org/x/sys v0.0.0-20210927094055-39ccf1dd6fa6/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg=
-golang.org/x/sys v0.0.0-20220204135822-1c1b9b1eba6a h1:ppl5mZgokTT8uPkmYOyEUmPTr3ypaKkg5eFOGrAmxxE=
-golang.org/x/sys v0.0.0-20220204135822-1c1b9b1eba6a/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg=
 golang.org/x/text v0.3.0/go.mod h1:NqM8EUOU14njkJ3fqMW+pc6Ldnwhi/IjpwHt7yyuwOQ=
 golang.org/x/tools v0.0.0-20190311212946-11955173bddd/go.mod h1:LCzVGOaR6xXOjkQ3onu1FJEFr0SW1gC7cKk1uF8kGRs=
 golang.org/x/tools v0.0.0-20190621195816-6e04913cbbac/go.mod h1:/rFqwRUd4F7ZHNgwSSTFct+R/Kf4OFW1sUzUTQQTgfc=
@@ -93,7 +67,6 @@ gopkg.in/check.v1 v0.0.0-20161208181325-20d25e280405/go.mod h1:Co6ibVJAznAaIkqp8
 gopkg.in/check.v1 v1.0.0-20180628173108-788fd7840127/go.mod h1:Co6ibVJAznAaIkqp8huTwlJQCZ016jof/cbN4VW5Yz0=
 gopkg.in/errgo.v2 v2.1.0/go.mod h1:hNsd1EY+bozCKY1Ytp96fpM3vjJbqLJn88ws8XvfDNI=
 gopkg.in/yaml.v2 v2.2.2/go.mod h1:hI93XBmqTisBFMUTm0b8Fm+jr3Dg1NNxqwp+5A1VGuI=
-gopkg.in/yaml.v2 v2.2.3/go.mod h1:hI93XBmqTisBFMUTm0b8Fm+jr3Dg1NNxqwp+5A1VGuI=
 gopkg.in/yaml.v2 v2.4.0 h1:D8xgwECY7CYvx+Y2n4sBz93Jn9JRvxdiyyo8CTfuKaY=
 gopkg.in/yaml.v2 v2.4.0/go.mod h1:RDklbk79AGWmwhnvt/jBztapEOGDOx6ZbXqjP6csGnQ=
 honnef.co/go/tools v0.0.1-2019.2.3/go.mod h1:a3bituU0lyd329TUQxRnasdCoJDkEUEAqEt0JzvZhAg=

internal/edgeapps/edgeapps.go

@@ -56,14 +56,14 @@ func GetEdgeApp(ID string) MaybeEdgeApp {
 		Valid:   false,
 	}
 
-	_, err := os.Stat(utils.GetPath("edgeAppsPath") + ID + configFilename)
+	_, err := os.Stat(utils.GetPath(utils.EdgeAppsPath) + ID + configFilename)
 	if !os.IsNotExist(err) {
 		// File exists. Start digging!
 
 		edgeAppName := ID
 		edgeAppDescription := ""
 
-		edgeAppEnv, err := godotenv.Read(utils.GetPath("edgeAppsPath") + ID + envFilename)
+		edgeAppEnv, err := godotenv.Read(utils.GetPath(utils.EdgeAppsPath) + ID + envFilename)
 
 		if err != nil {
 			log.Println("Error loading .env file for edgeapp " + edgeAppName)
@@ -79,10 +79,9 @@ func GetEdgeApp(ID string) MaybeEdgeApp {
 		edgeAppInternetAccessible := false
 		edgeAppInternetURL := ""
 
-		myEdgeAppServiceEnv, err := godotenv.Read(utils.GetPath("edgeAppsPath") + ID + myEdgeAppServiceEnvFilename)
+		myEdgeAppServiceEnv, err := godotenv.Read(utils.GetPath(utils.EdgeAppsPath) + ID + myEdgeAppServiceEnvFilename)
 		if err != nil {
-			// log.Println("No myedge.app environment file found. Status is Network-Only")
+			log.Println("No myedge.app environment file found. Status is Network-Only")
-			// File probably not found!
 		} else {
 			if myEdgeAppServiceEnv["INTERNET_URL"] != "" {
 				edgeAppInternetAccessible = true
@@ -114,7 +113,7 @@ func IsEdgeAppInstalled(ID string) bool {
 
 	result := false
 
-	_, err := os.Stat(utils.GetPath("edgeAppsPath") + ID + runnableFilename)
+	_, err := os.Stat(utils.GetPath(utils.EdgeAppsPath) + ID + runnableFilename)
 	if !os.IsNotExist(err) {
 		result = true
 	}
@@ -126,11 +125,12 @@ func IsEdgeAppInstalled(ID string) bool {
 func SetEdgeAppInstalled(ID string) bool {
 
 	result := true
+	edgeAppPath := utils.GetPath(utils.EdgeAppsPath)
 
-	_, err := os.Stat(utils.GetPath("edgeAppsPath") + ID + runnableFilename)
+	_, err := os.Stat(edgeAppPath + ID + runnableFilename)
 	if os.IsNotExist(err) {
 
-		_, err := os.Create(utils.GetPath("edgeAppsPath") + ID + runnableFilename)
+		_, err := os.Create(edgeAppPath + ID + runnableFilename)
 		result = true
 
 		if err != nil {
@@ -154,7 +154,7 @@ func SetEdgeAppInstalled(ID string) bool {
 func SetEdgeAppNotInstalled(ID string) bool {
 
 	result := true
-	err := os.Remove(utils.GetPath("edgeAppsPath") + ID + runnableFilename)
+	err := os.Remove(utils.GetPath(utils.EdgeAppsPath) + ID + runnableFilename)
 	if err != nil {
 		result = false
 		log.Fatal(err)
@@ -173,7 +173,7 @@ func GetEdgeApps() []EdgeApp {
 
 	// Building list of available edgeapps in the system with their status
 
-	files, err := ioutil.ReadDir(utils.GetPath("edgeAppsPath"))
+	files, err := ioutil.ReadDir(utils.GetPath(utils.EdgeAppsPath))
 	if err != nil {
 		log.Fatal(err)
 	}
@@ -236,18 +236,18 @@ func GetEdgeAppStatus(ID string) EdgeAppStatus {
 
 }
 
-// GetEdgeAppServices : Returns a list of services for a single edgeapp
+// GetEdgeAppServices : Returns a
 func GetEdgeAppServices(ID string) []EdgeAppService {
-
+	wsPath := utils.GetPath(utils.WsPath)
-	cmdArgs := []string{"-r", ".services | keys[]", utils.GetPath("edgeAppsPath") + ID + configFilename}
+	cmdArgs := []string{"-r", ".services | keys[]", utils.GetPath(utils.EdgeAppsPath) + ID + configFilename}
-	servicesString := utils.Exec(utils.GetPath("wsPath"), "yq", cmdArgs)
+	servicesString := utils.Exec(utils.GetPath(utils.WsPath), "yq", cmdArgs)
 	serviceSlices := strings.Split(servicesString, "\n")
 	serviceSlices = utils.DeleteEmptySlices(serviceSlices)
 	var edgeAppServices []EdgeAppService
 
 	for _, serviceID := range serviceSlices {
-		cmdArgs = []string{"-f", utils.GetPath("wsPath") + "/docker-compose.yml", "exec", "-T", serviceID, "echo", "'Service Check'"}
+		cmdArgs = []string{"-f", wsPath + "/docker-compose.yml", "exec", "-T", serviceID, "echo", "'Service Check'"}
-		cmdResult := utils.Exec(utils.GetPath("wsPath"), "docker-compose", cmdArgs)
+		cmdResult := utils.Exec(wsPath, "docker-compose", cmdArgs)
 		isRunning := false
 		if cmdResult != "" {
 			isRunning = true
@@ -261,16 +261,14 @@ func GetEdgeAppServices(ID string) []EdgeAppService {
 
 // RunEdgeApp : Run an EdgeApp and return its most current status
 func RunEdgeApp(ID string) EdgeAppStatus {
-
+	wsPath := utils.GetPath(utils.WsPath)
 	services := GetEdgeAppServices(ID)
-
 	cmdArgs := []string{}
 
 	for _, service := range services {
 
-		cmdArgs = []string{"-f", utils.GetPath("wsPath") + "/docker-compose.yml", "start", service.ID}
+		cmdArgs = []string{"-f", wsPath + "/docker-compose.yml", "start", service.ID}
-		utils.Exec(utils.GetPath("wsPath"), "docker-compose", cmdArgs)
+		utils.Exec(wsPath, "docker-compose", cmdArgs)
-
 	}
 
 	// Wait for it to settle up before continuing...
@@ -282,16 +280,13 @@ func RunEdgeApp(ID string) EdgeAppStatus {
 
 // StopEdgeApp : Stops an EdgeApp and return its most current status
 func StopEdgeApp(ID string) EdgeAppStatus {
-
+	wsPath := utils.GetPath(utils.WsPath)
 	services := GetEdgeAppServices(ID)
-
 	cmdArgs := []string{}
-
 	for _, service := range services {
 
-		cmdArgs = []string{"-f", utils.GetPath("wsPath") + "/docker-compose.yml", "stop", service.ID}
+		cmdArgs = []string{"-f", wsPath + "/docker-compose.yml", "stop", service.ID}
-		utils.Exec(utils.GetPath("wsPath"), "docker-compose", cmdArgs)
+		utils.Exec(wsPath, "docker-compose", cmdArgs)
-
 	}
 
 	// Wait for it to settle up before continuing...
@@ -307,7 +302,7 @@ func EnableOnline(ID string, InternetURL string) MaybeEdgeApp {
 	maybeEdgeApp := GetEdgeApp(ID)
 	if maybeEdgeApp.Valid { // We're only going to do this operation if the EdgeApp actually exists.
 		// Create the myedgeapp.env file and add the InternetURL entry to it
-		envFilePath := utils.GetPath("edgeAppsPath") + ID + myEdgeAppServiceEnvFilename
+		envFilePath := utils.GetPath(utils.EdgeAppsPath) + ID + myEdgeAppServiceEnvFilename
 		env, _ := godotenv.Unmarshal("INTERNET_URL=" + InternetURL)
 		_ = godotenv.Write(env, envFilePath)
 	}
@@ -321,13 +316,13 @@ func EnableOnline(ID string, InternetURL string) MaybeEdgeApp {
 // DisableOnline : Removes env files necessary for system external access config. Rebuilds containers in project (in case of change only).
 func DisableOnline(ID string) MaybeEdgeApp {
 
-	envFilePath := utils.GetPath("edgeAppsPath") + ID + myEdgeAppServiceEnvFilename
+	envFilePath := utils.GetPath(utils.EdgeAppsPath) + ID + myEdgeAppServiceEnvFilename
 	_, err := godotenv.Read(envFilePath)
 	if err != nil {
 		log.Println("myedge.app environment file for " + ID + " not found. No need to delete.")
 	} else {
 		cmdArgs := []string{envFilePath}
-		utils.Exec(utils.GetPath("wsPath"), "rm", cmdArgs)
+		utils.Exec(utils.GetPath(utils.WsPath), "rm", cmdArgs)
 	}
 
 	buildFrameworkContainers()
@@ -338,7 +333,7 @@ func DisableOnline(ID string) MaybeEdgeApp {
 
 func EnablePublicDashboard(InternetURL string) bool {
 
-	envFilePath := utils.GetPath("apiPath") + myEdgeAppServiceEnvFilename
+	envFilePath := utils.GetPath(utils.ApiPath) + myEdgeAppServiceEnvFilename
 	env, _ := godotenv.Unmarshal("INTERNET_URL=" + InternetURL)
 	_ = godotenv.Write(env, envFilePath)
 
@@ -349,28 +344,29 @@ func EnablePublicDashboard(InternetURL string) bool {
 }
 
 func DisablePublicDashboard() bool {
-	envFilePath := utils.GetPath("apiPath") + myEdgeAppServiceEnvFilename
+	envFilePath := utils.GetPath(utils.ApiPath) + myEdgeAppServiceEnvFilename
 	if !IsPublicDashboard() {
 		log.Println("myedge.app environment file for the dashboard / api not found. No need to delete.")
 		return false
 	}
 
 	cmdArgs := []string{envFilePath}
-	utils.Exec(utils.GetPath("apiPath"), "rm", cmdArgs)
+	utils.Exec(utils.GetPath(utils.ApiPath), "rm", cmdArgs)
 	buildFrameworkContainers()
 	return true
 }
 
 func IsPublicDashboard() bool {
-	envFilePath := utils.GetPath("apiPath") + myEdgeAppServiceEnvFilename
+	envFilePath := utils.GetPath(utils.ApiPath) + myEdgeAppServiceEnvFilename
 	_, err := godotenv.Read(envFilePath)
 	return err == nil
 }
 
 func buildFrameworkContainers() {
 
-	cmdArgs := []string{utils.GetPath("wsPath") + "ws", "--build"}
+	wsPath := utils.GetPath(utils.WsPath)
-	utils.ExecAndStream(utils.GetPath("wsPath"), "sh", cmdArgs)
+	cmdArgs := []string{wsPath + "ws", "--build"}
+	utils.ExecAndStream(wsPath, "sh", cmdArgs)
 
 	time.Sleep(defaultContainerOperationSleepTime)
 

internal/storage/storage.go

@@ -224,9 +224,9 @@ func getDevicesSpaceUsage(devices []Device) []Device {
 					bucketsUsageSplit := (uint64)(0)
 					othersUsageSplit := (uint64)(0)
 
-					edgeappsDirSize, _ := getDirSize(utils.GetPath("edgeAppsPath"))
+					edgeappsDirSize, _ := getDirSize(utils.GetPath(utils.EdgeAppsPath))
 					// TODO for later: Figure out to get correct paths for each partition...
-					wsAppDataDirSize, _ := getDirSize("/home/system/components/ws/appdata")
+					wsAppDataDirSize, _ := getDirSize(utils.GetPath(utils.WsPath) + "/appdata")
 
 					if partition.Mountpoint == "/" {
 						edgeappsUsageSplit = edgeappsDirSize + wsAppDataDirSize

internal/system/system.go

@@ -7,9 +7,8 @@ import (
 
 	"github.com/edgebox-iot/edgeboxctl/internal/utils"
 
-	"github.com/shirou/gopsutil/host"
 	"github.com/joho/godotenv"
-
+	"github.com/shirou/gopsutil/host"
 )
 
 // GetUptimeInSeconds: Returns a value (as string) of the total system uptime
@@ -64,7 +63,8 @@ func GetHostname() string {
 func SetupCloudOptions() {
 
 	var cloudEnv map[string]string
-	cloudEnv, err := godotenv.Read(utils.GetPath("cloudEnvFileLocation"))
+	cloudEnvFileLocationPath := utils.GetPath(utils.CloudEnvFileLocation)
+	cloudEnv, err := godotenv.Read(cloudEnvFileLocationPath)
 
 	if err != nil {
 		fmt.Println("Error loading .env file for cloud version setup")
@@ -83,6 +83,5 @@ func SetupCloudOptions() {
 	}
 
 	// In the end of this operation takes place, remove the env file as to not overwrite any options once they are set.
-	utils.Exec("/", "rm", []string{utils.GetPath("cloudEnvFileLocation")})
+	utils.Exec("/", "rm", []string{cloudEnvFileLocationPath})
-
 }

internal/tasks/tasks.go

@@ -69,23 +69,6 @@ const STATUS_EXECUTING int = 1
 const STATUS_FINISHED int = 2
 const STATUS_ERROR int = 3
 
-func GetBaseTask(taskCode string, argsString string) Task {
-	currentFormattedTime := utils.GetFormattedDateTime(time.Now())
-	task := Task{
-		ID:   0,
-		Task: taskCode,
-		Args: sql.NullString{
-			String: argsString,
-			Valid:  true,
-		},
-		Status:  fmt.Sprintf("%d", STATUS_CREATED),
-		Created: currentFormattedTime,
-		Updated: currentFormattedTime,
-	}
-
-	return task
-}
-
 // GetNextTask : Performs a MySQL query over the device's Edgebox API
 func GetNextTask() Task {
 
@@ -136,7 +119,7 @@ func ExecuteTask(task Task) Task {
 		log.Fatal(err.Error())
 	}
 
-	formatedDatetime := utils.GetFormattedDateTime(time.Now())
+	formatedDatetime := utils.GetSQLiteFormattedDateTime(time.Now())
 
 	_, err = statement.Exec(STATUS_EXECUTING, formatedDatetime, strconv.Itoa(task.ID)) // Execute SQL Statement
 	if err != nil {
@@ -146,8 +129,8 @@ func ExecuteTask(task Task) Task {
 	if diagnostics.GetReleaseVersion() == diagnostics.DEV_VERSION {
 		log.Printf("Dev environemnt. Not executing tasks.")
 	} else {
-		// log.Println("Task: " + task.Task)
+		log.Println("Task: " + task.Task)
-		// log.Println("Args: " + task.Args.String)
+		log.Println("Args: " + task.Args.String)
 		switch task.Task {
 		case "setup_tunnel":
 
@@ -161,12 +144,6 @@ func ExecuteTask(task Task) Task {
 				task.Result = sql.NullString{String: taskResult, Valid: true}
 			}
 
-		case "list_edgeapps":
-
-			log.Println("Fetching current status on Edgeapps...")
-			taskResult := taskGetEdgeApps()
-			task.Result = sql.NullString{String: taskResult, Valid: true}
-
 		case "install_edgeapp":
 
 			log.Println("Installing EdgeApp...")
@@ -269,7 +246,7 @@ func ExecuteTask(task Task) Task {
 		log.Fatal(err.Error())
 	}
 
-	formatedDatetime = utils.GetFormattedDateTime(time.Now())
+	formatedDatetime = utils.GetSQLiteFormattedDateTime(time.Now())
 
 	if task.Result.Valid {
 		_, err = statement.Exec(STATUS_FINISHED, task.Result.String, formatedDatetime, strconv.Itoa(task.ID)) // Execute SQL Statement with result info
@@ -350,23 +327,24 @@ func ExecuteSchedules(tick int) {
 }
 
 func taskSetupTunnel(args taskSetupTunnelArgs) string {
-	// // fmt.Println("Executing taskSetupTunnel")
+	fmt.Println("Executing taskSetupTunnel")
 
+	wsPath := utils.GetPath(utils.WsPath)
 	cmdargs := []string{"gen", "--name", args.NodeName, "--token", args.BootnodeToken, args.BootnodeAddress + ":8655", "--prefix", args.AssignedAddress}
-	utils.Exec(utils.GetPath("wsPath"), "tinc-boot", cmdargs)
+	utils.Exec(wsPath, "tinc-boot", cmdargs)
 
 	cmdargs = []string{"start", "tinc@dnet"}
-	utils.Exec(utils.GetPath("wsPath"), "systemctl", cmdargs)
+	utils.Exec(wsPath, "systemctl", cmdargs)
 
 	cmdargs = []string{"enable", "tinc@dnet"}
-	utils.Exec(utils.GetPath("wsPath"), "systemctl", cmdargs)
+	utils.Exec(wsPath, "systemctl", cmdargs)
 
 	output := "OK" // Better check / logging of command execution result.
 	return output
 }
 
 func taskInstallEdgeApp(args taskInstallEdgeAppArgs) string {
-	// fmt.Println("Executing taskInstallEdgeApp for " + args.ID)
+	fmt.Println("Executing taskInstallEdgeApp for " + args.ID)
 
 	result := edgeapps.SetEdgeAppInstalled(args.ID)
 	resultJSON, _ := json.Marshal(result)
@@ -376,7 +354,7 @@ func taskInstallEdgeApp(args taskInstallEdgeAppArgs) string {
 }
 
 func taskRemoveEdgeApp(args taskRemoveEdgeAppArgs) string {
-	// fmt.Println("Executing taskRemoveEdgeApp for " + args.ID)
+	fmt.Println("Executing taskRemoveEdgeApp for " + args.ID)
 
 	// Making sure the application is stopped before setting it as removed.
 	edgeapps.StopEdgeApp(args.ID)
@@ -388,7 +366,7 @@ func taskRemoveEdgeApp(args taskRemoveEdgeAppArgs) string {
 }
 
 func taskStartEdgeApp(args taskStartEdgeAppArgs) string {
-	// fmt.Println("Executing taskStartEdgeApp for " + args.ID)
+	fmt.Println("Executing taskStartEdgeApp for " + args.ID)
 
 	result := edgeapps.RunEdgeApp(args.ID)
 	resultJSON, _ := json.Marshal(result)
@@ -398,7 +376,7 @@ func taskStartEdgeApp(args taskStartEdgeAppArgs) string {
 }
 
 func taskStopEdgeApp(args taskStopEdgeAppArgs) string {
-	// fmt.Println("Executing taskStopEdgeApp for " + args.ID)
+	fmt.Println("Executing taskStopEdgeApp for " + args.ID)
 
 	result := edgeapps.StopEdgeApp(args.ID)
 	resultJSON, _ := json.Marshal(result)
@@ -408,7 +386,7 @@ func taskStopEdgeApp(args taskStopEdgeAppArgs) string {
 }
 
 func taskEnableOnline(args taskEnableOnlineArgs) string {
-	// fmt.Println("Executing taskEnableOnline for " + args.ID)
+	fmt.Println("Executing taskEnableOnline for " + args.ID)
 
 	result := edgeapps.EnableOnline(args.ID, args.InternetURL)
 	resultJSON, _ := json.Marshal(result)
@@ -418,7 +396,7 @@ func taskEnableOnline(args taskEnableOnlineArgs) string {
 }
 
 func taskDisableOnline(args taskDisableOnlineArgs) string {
-	// fmt.Println("Executing taskDisableOnline for " + args.ID)
+	fmt.Println("Executing taskDisableOnline for " + args.ID)
 
 	result := edgeapps.DisableOnline(args.ID)
 	resultJSON, _ := json.Marshal(result)
@@ -428,7 +406,7 @@ func taskDisableOnline(args taskDisableOnlineArgs) string {
 }
 
 func taskEnablePublicDashboard(args taskEnablePublicDashboardArgs) string {
-	// fmt.Println("Enabling taskEnablePublicDashboard")
+	fmt.Println("Enabling taskEnablePublicDashboard")
 	result := edgeapps.EnablePublicDashboard(args.InternetURL)
 	if result {
 
@@ -441,7 +419,7 @@ func taskEnablePublicDashboard(args taskEnablePublicDashboardArgs) string {
 }
 
 func taskDisablePublicDashboard() string {
-	// fmt.Println("Executing taskDisablePublicDashboard")
+	fmt.Println("Executing taskDisablePublicDashboard")
 	result := edgeapps.DisablePublicDashboard()
 	utils.WriteOption("PUBLIC_DASHBOARD", "")
 	if result {
@@ -452,7 +430,7 @@ func taskDisablePublicDashboard() string {
 
 func taskSetReleaseVersion() string {
 
-	// fmt.Println("Executing taskSetReleaseVersion")
+	fmt.Println("Executing taskSetReleaseVersion")
 
 	utils.WriteOption("RELEASE_VERSION", diagnostics.Version)
 
@@ -460,7 +438,7 @@ func taskSetReleaseVersion() string {
 }
 
 func taskGetEdgeApps() string {
-	// fmt.Println("Executing taskGetEdgeApps")
+	fmt.Println("Executing taskGetEdgeApps")
 
 	edgeApps := edgeapps.GetEdgeApps()
 	edgeAppsJSON, _ := json.Marshal(edgeApps)
@@ -470,14 +448,14 @@ func taskGetEdgeApps() string {
 }
 
 func taskGetSystemUptime() string {
-	// fmt.Println("Executing taskGetSystemUptime")
+	fmt.Println("Executing taskGetSystemUptime")
 	uptime := system.GetUptimeInSeconds()
 	utils.WriteOption("SYSTEM_UPTIME", uptime)
 	return uptime
 }
 
 func taskGetStorageDevices() string {
-	// fmt.Println("Executing taskGetStorageDevices")
+	fmt.Println("Executing taskGetStorageDevices")
 
 	devices := storage.GetDevices(diagnostics.GetReleaseVersion())
 	devicesJSON, _ := json.Marshal(devices)
@@ -488,20 +466,20 @@ func taskGetStorageDevices() string {
 }
 
 func taskGetSystemIP() string {
-	// fmt.Println("Executing taskGetStorageDevices")
+	fmt.Println("Executing taskGetStorageDevices")
 	ip := system.GetIP()
 	utils.WriteOption("IP_ADDRESS", ip)
 	return ip
 }
 
 func taskGetHostname() string {
-	// fmt.Println("Executing taskGetHostname")
+	fmt.Println("Executing taskGetHostname")
 	hostname := system.GetHostname()
 	utils.WriteOption("HOSTNAME", hostname)
 	return hostname
 }
 
 func taskSetupCloudOptions() {
-	// fmt.Println("Executing taskSetupCloudOptions")
+	fmt.Println("Executing taskSetupCloudOptions")
 	system.SetupCloudOptions()
 }

internal/utils/utils.go

@@ -4,7 +4,6 @@ import (
 	"bufio"
 	"bytes"
 	"database/sql"
-	"encoding/json"
 	"fmt"
 	"io"
 	"log"
@@ -13,7 +12,6 @@ import (
 	"strings"
 	"time"
 
-	"github.com/TylerBrock/colorjson"
 	"github.com/joho/godotenv"
 )
 
@@ -83,7 +81,7 @@ func DeleteEmptySlices(s []string) []string {
 func GetSQLiteDbConnectionDetails() string {
 
 	var apiEnv map[string]string
-	apiEnv, err := godotenv.Read(GetPath("apiEnvFileLocation"))
+	apiEnv, err := godotenv.Read(GetPath(ApiEnvFileLocation))
 
 	if err != nil {
 		log.Fatal("Error loading .env file")
@@ -93,8 +91,8 @@ func GetSQLiteDbConnectionDetails() string {
 
 }
 
-// GetFormattedDateTime: Given a Time, Returns a string that is formatted to be passed around the application, including correctly inserting SQLite Datetime field using sql.Prepare.
+// GetSQLiteFormattedDateTime: Given a Time, Returns a string that is formatted ready to be inserted into an SQLite Datetime field using sql.Prepare.
-func GetFormattedDateTime(t time.Time) string {
+func GetSQLiteFormattedDateTime(t time.Time) string {
 	// This date is used to indicate the layout.
 	const datetimeLayout = "2006-01-02 15:04:05"
 	formatedDatetime := t.Format(datetimeLayout)
@@ -102,6 +100,12 @@ func GetFormattedDateTime(t time.Time) string {
 	return formatedDatetime
 }
 
+const CloudEnvFileLocation string = "cloudEnvFileLocation"
+const ApiEnvFileLocation string = "apiEnvFileLocation"
+const ApiPath string = "apiPath"
+const EdgeAppsPath string = "edgeAppsPath"
+const WsPath string = "wsPath"
+
 // GetPath : Returns either the hardcoded path, or a overwritten value via .env file at project root. Register paths here for seamless working code between dev and prod environments ;)
 func GetPath(pathKey string) string {
 
@@ -115,7 +119,7 @@ func GetPath(pathKey string) string {
 	}
 
 	switch pathKey {
-	case "cloudEnvFileLocation":
+	case CloudEnvFileLocation:
 
 		if env["CLOUD_ENV_FILE_LOCATION"] != "" {
 			targetPath = env["CLOUD_ENV_FILE_LOCATION"]
@@ -123,7 +127,7 @@ func GetPath(pathKey string) string {
 			targetPath = "/home/system/components/edgeboxctl/cloud.env"
 		}
 
-	case "apiEnvFileLocation":
+	case ApiEnvFileLocation:
 
 		if env["API_ENV_FILE_LOCATION"] != "" {
 			targetPath = env["API_ENV_FILE_LOCATION"]
@@ -131,15 +135,15 @@ func GetPath(pathKey string) string {
 			targetPath = "/home/system/components/api/edgebox.env"
 		}
 
-	case "apiPath":
+	case ApiPath:
 
 		if env["API_PATH"] != "" {
-			targetPath = env["APT_PATH"]
+			targetPath = env["API_PATH"]
 		} else {
 			targetPath = "/home/system/components/api/"
 		}
 
-	case "edgeAppsPath":
+	case EdgeAppsPath:
 
 		if env["EDGEAPPS_PATH"] != "" {
 			targetPath = env["EDGEAPPS_PATH"]
@@ -147,7 +151,7 @@ func GetPath(pathKey string) string {
 			targetPath = "/home/system/components/apps/"
 		}
 
-	case "wsPath":
+	case WsPath:
 
 		if env["WS_PATH"] != "" {
 			targetPath = env["WS_PATH"]
@@ -179,7 +183,7 @@ func WriteOption(optionKey string, optionValue string) {
 		log.Fatal(err.Error())
 	}
 
-	formatedDatetime := GetFormattedDateTime(time.Now())
+	formatedDatetime := GetSQLiteFormattedDateTime(time.Now())
 
 	_, err = statement.Exec(optionKey, optionValue, formatedDatetime, formatedDatetime) // Execute SQL Statement
 	if err != nil {
@@ -188,21 +192,3 @@ func WriteOption(optionKey string, optionValue string) {
 
 	db.Close()
 }
-
-// IsSystemReady : Checks readiness of the service to execute commands (Only after "edgebox --build" is ran at least once via SSH, or if built for distribution)
-func IsSystemReady() bool {
-	_, err := os.Stat(GetPath("wsPath") + ".ready")
-	return !os.IsNotExist(err)
-}
-
-// IsDatabaseReady : Checks is it can successfully connect to the task queue db
-func IsDatabaseReady() bool {
-	return false
-}
-
-func ColorJsonString(jsonString string) string {
-	var obj map[string]interface{}
-	json.Unmarshal([]byte(jsonString), &obj)
-	resultJSON, _ := colorjson.Marshal(obj)
-	return string(resultJSON)
-}

internal/utils/utils_test.go

@@ -89,17 +89,16 @@ func TestGetPath(t *testing.T) {
 		t.Fail()
 	}
 
-	validPathKey := "wsPath"
+	result = GetPath(WsPath)
-	result = GetPath(validPathKey)
 	if result != "/home/system/components/ws/" {
 		t.Log("Expected /home/system/components/ws/ but got", result)
 		t.Fail()
 	}
 }
 
-func TestGetFormattedDateTime(t *testing.T) {
+func TestGetSQLiteFormattedDateTime(t *testing.T) {
 	datetime := time.Date(2021, time.Month(1), 01, 1, 30, 15, 0, time.UTC)
-	result := GetFormattedDateTime(datetime)
+	result := GetSQLiteFormattedDateTime(datetime)
 
 	if result != "2021-01-01 01:30:15" {
 		t.Log("Expected 2021-01-01 01:30:15 but got ", result)